[vlc-devel] [PATCH] opengl: enables shaders for macos opengl.

[Sebastien Zwickert]

On Sep 15, 2011, at 10:53 PM, Jean-Baptiste Kempf wrote:

> On Thu, Sep 15, 2011 at 09:40:14PM +0200, Laurent Aimar wrote :
>> On Thu, Sep 15, 2011 at 10:21:35AM +0200, Sebastien Zwickert wrote:
>>> 
>>> On Sep 15, 2011, at 12:07 AM, Sebastien Zwickert wrote:
>>>> --
>>>> <0008-opengl-enables-shaders-for-macos-opengl-an-cleans-so.patch>
>>> 
>>> Same patch in attachment without printf. Ahuuuu! ;)
>> 
>> No more comments/objections on my part. I will let a macosx dev confirms
>> and commits.
> 
> Not really a mac os dev, but tested and seems working. I doubt we can do
> much better now.
> 
> Having a performance test with -Vdummy in 1.1 and 1.2 would be cool
> though...

I've done some performance tests between -V dummy in 1.1 and 1.2 using Shark profiler.
For each release I've done five Time Profile samplings of 60 seconds each one when
VLC was playing the first minute of HD H264 video (Big Duck Bunny).
I made an average of the results of the samplings and I compared the results of the two versions.
So VLC 1.2 patched with the last version of the patch of this mailing list thread has better
performances than VLC 1.1.
Execution time is mostly taken by libavcodec which took ~78% in 1.1 release and only ~70% in 1.2.
While adding the results of the 5 libraries that took the most execution time (libavcodec, DspFuncLib, libfaad, AppKit)
it appears that 1.2 patched results take 10% less of execution time that 1.1 (83% VS 93%).

I can provide somewhere the set of samplings if needed.

Best regards,

Sebastien.