[vlc-devel] [RFC] [PATCH 0/2] IOMX support for Android

Martin Storsjö martin at martin.st
Wed Sep 21 14:49:31 CEST 2011

This is the reworked IOMX support for Android.

Compared to the code in the previous version, this keeps
omxil.c as plain C (and only has some very minimal changes,
to hook in the IOMX code), and contains all the C++ code in a
separate file, which implements a normal OMX interface
outwards, which omxil.c then uses, relaying the calls to IOMX.

This is still very much a RFC patchset. Things that might
need attention:
- Missing check for the right headers in configure.ac
- This creates a separate module "iomx", which builds from the
  same source files as the "omxil" module. Is this ok, or would
  it better to keep it named the same, but enabling this behaviour
  only if some configure flag is specified? The separate module
  has some ugly workaround to conditionally set a define when
  building omxil.c for the iomx module.
- Coding style (I'm not that used to the VLC style, sorry)

Martin Storsjö (2):
  omxil: Make GetAudioParamSize nonstatic
  omxil: Allow using IOMX on Android

 configure.ac                      |   12 ++
 modules/codec/omxil/Modules.am    |    4 +
 modules/codec/omxil/iomx.cpp      |  394 +++++++++++++++++++++++++++++++++++++
 modules/codec/omxil/iomx.h        |   33 +++
 modules/codec/omxil/omxil-iomx.c  |    2 +
 modules/codec/omxil/omxil.c       |    7 +
 modules/codec/omxil/omxil_utils.h |    1 +
 modules/codec/omxil/utils.c       |    2 +-
 8 files changed, 454 insertions(+), 1 deletions(-)
 create mode 100644 modules/codec/omxil/iomx.cpp
 create mode 100644 modules/codec/omxil/iomx.h
 create mode 100644 modules/codec/omxil/omxil-iomx.c


More information about the vlc-devel mailing list