[vlc-devel] [PATCH 1/3] omxil: Set OMX version 1.0.0 when using IOMX

[Martin Storsjö]

On Thu, 22 Sep 2011, Jean-Baptiste Kempf wrote:

> On Thu, Sep 22, 2011 at 02:21:55PM +0300, Martin Storsjö wrote :
>> Hmm, do you mean using __ANDROID__ (or something similar) instead of
>> USE_IOMX (which in itself never is defined outside of android), or
>> just moving the definitions of the actual values out from the
>> OMX_INIT_COMMON definition?
>
> I think both. :D
>
> I might be wrong, but the stagefright requiring 1.0.0 is an Android
> thing, not a IOMX thing: if you root your device and use plain OMX, it
> might work.

Ah, yeah, good point.

> I think moving out the values from the definition will help, so we don't
> have 20 definitions of the macro the day there are 20 platforms
> supported.

Yes, that might become an issue.

I'll have a try :-)

// Martin