[vlc-devel] [PATCH] Added option to disable chapter generation from marks file.
jikuja at iki.fi
Thu Sep 22 20:29:33 CEST 2011
On 22.9.2011 19:12, Jean-Baptiste Kempf wrote:
> On Thu, Sep 22, 2011 at 02:52:05AM +0300, Janne Kujanpää wrote :
>> + int64_t i_last_frame = -10000;
> Why not -1 ?
It's not enough. If there is cutmark just beginning of file it will
cause chapters not to be created. Added macro to use as initial value
and inside if clause.
>> + if ( i_frame - i_last_frame< 45 )
> Trailing space.
>> + i_last_frame=i_frame;
> Missing spaces around "="
Time to read code conventions again and recheck twice before send.
Fixed version as an attachment.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the vlc-devel