[vlc-devel] [PATCH 1/2] Split SPS/PPS parsing and annex b conversion to a reusable utility function

[Jean-Baptiste Kempf]

On Wed, Sep 28, 2011 at 06:26:39PM +0300, Martin Storsjö wrote :
> The actual functionality shouldn't be broken (since I've tested
> it in the omxil module), but please make sure it still builds,
> since I don't have a build configuration that uses crystalhd
> at the moment.

It doesn't. :D

>  static picture_t *DecodeBlock   ( decoder_t *p_dec, block_t **pp_block );
>  // static void crystal_CopyPicture ( picture_t *, BC_DTS_PROC_OUT* );
> -static int crystal_insert_sps_pps(decoder_t *, uint8_t *, uint32_t);

No, keep this.

> +/* Parse the SPS/PPS Metadata and convert it to annex b format */
> +static int convert_sps_pps( decoder_t *p_dec, const uint8_t *p_buf,
> +                            uint32_t i_buf_size, uint8_t *p_out_buf,
> +                            uint32_t i_out_buf_size, uint32_t *p_sps_pps_size,
> +                            int *p_nal_size)

p_nal_size should be unsigned, to fit the old code, I think.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device