[vlc-devel] [PATCH] TS demux: get time and length

[Janne Kujanpää]

On 29.9.2011 18:20, Naohiro KORIYAMA wrote:
> Hi,
>
> 2011/9/25 Laurent Aimar<fenrir at elivagar.org>:
>> On Fri, Sep 23, 2011 at 11:17:57AM +0900, Naohiro KORIYAMA wrote:
>> There are two differents issues:
>> 1. Handle files that have PCR restarting without it being due to a PCR wrap.
>> 2. Handle files longer than 1 PCR wraps (more than ~ 26 hours).
>
> I added a table for checking PCR wrap around.
> This modification solved the issues and made a little bit improvement
> for Seek().
>
> Regards,
>
Hello, I tested your patch with vdr and file access modules. Results:

***Continuous PCR***:
"--access=vdr --ts-seek-percent"
OK
"--access=file --ts-seek-percent"
OK
"--access=vdr"
OK
"--access=file"
OK
This was simple, all ok and working.


***Edited files***:
Always wrong length and time. Should this be documented into help text 
or NEWS-file?

"--access=vdr --ts-seek-percent"
(1)
Seekbar no more jumpy. Seeking with seekbar OK.

"--access=file --ts-seek-percent"
Seekbar no more jumpy. Seeking OK

"--access=vdr"
(1), (2)

"--access=file"
(2)


(1) bug with vanilla 1.2 too: no prev chapter. Prevs only into nearest
(2) INPUT_CONTROL_SET_POSITION(_OFFSET) 95.6% failed
does it change seek method after first fail?


No regressions detected. Nice fallback into percent based seek if new 
method fails.
Regards,

-- 
Janne Kujanpää