[vlc-devel] [vlc-commits] Fix AAC encoding with ffaac

[Måns Rullgård]

Jean-Baptiste Kempf <jb at videolan.org> writes:

> On Sun, Apr 01, 2012 at 11:26:31AM -0400, Rafaël Carré wrote :
>> Le 2012-04-01 15:23, Jean-Baptiste Kempf a écrit :
>> > On Sun, Apr 01, 2012 at 10:58:58AM -0400, Rafaël Carré wrote :
>> >> Since this codec is experimental, I think we should rather display a
>> >> message and let the user set this flag himself.
>> > 
>> > I disagree.
>> > AAC is a major codec and ffaac is the best we have.
>> 
>> I think libfaac is preferred to ffaac.
>
> libfaac is not GPL compatible.
>
> ffaac is crap, but we have nothing else.

Nothing at all is a huge improvement.  Allowing people to use that
encoder without seeing a giant, red, flashing warning message is
irresponsible.

-- 
Måns Rullgård
mans at mansr.com