[vlc-devel] [PATCH] Display cursor on video screenshot on X server systems using xfixes extension

[Jean-Baptiste Kempf]

Hello Mehdi,



On Tue, Apr 03, 2012 at 10:27:18AM +0200, Mehdi Lauters wrote :
> +//#include <xcb/xcb_image.h>

Useless.

> -    free (geo);
> +

Why?

> +///////////////////////////////////////////////cursor processing begining///////////////////////////////////
> +// doesn't take account of cursor transparency

Avoid those ugly comments... See the rest of the file for style.


> +	// initializing xfixes (to get the cursor image)
> +	xcb_xfixes_query_version_reply(conn, xcb_xfixes_query_version(conn, XCB_XFIXES_MAJOR_VERSION, XCB_XFIXES_MINOR_VERSION), NULL);

No tabs, please wrap at 80 columns.

> +	if(xcbError.error_code!=0)
> +	{
> +        msg_Warn (demux, "unable to locate cursor");

Indentation should be 4. Code indentation should follow the guidelines.

> diff --git a/po/fr.po b/po/fr.po

No.

Rejected in this form.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device