[vlc-devel] [PATCH] Speex_Resampler: reject samplerates above 96kHz

Jean-Baptiste Kempf jb at videolan.org
Fri Apr 6 11:30:39 CEST 2012


On Fri, Apr 06, 2012 at 08:34:25AM +0300, Rémi Denis-Courmont wrote :
> > Should close #5781
> 
> On integer pipelines, this will cause fallback to ugly... Right now it is not 
> much of an issue. But someone might want to optimize the audio output to, say, 
> use S16N when both decoder and output use S16N....

Indeed, I will write a big FIXME then.

> This is dubious. I would rather limitations depending on the resampling ratio 
> than the absolute output rate. But the problem might be as simple as fixing 
> buffer underflows.

This is very possible. My big issue is 2.0.2, for now, to be honest.
Maybe just commit that, in this branch?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list