[vlc-devel] [PATCH 3/5] demux/mp4: move some stuff in a header file

[Rémi Denis-Courmont]

On Wed, 11 Apr 2012 11:40:04 +0200, Frédéric Yhuel <fyhuel at viotech.net>
wrote:
> I need to include mp4_track_t definition in my Smooth Streaming module

demux_sys_t is intrinsically an internal structure of the MP4 demux. I
don't really see why you'd have to export it.

> ---
>  modules/demux/mp4/Modules.am |    1 +
>  modules/demux/mp4/mp4.c      |  109
+-----------------------------------
>  modules/demux/mp4/mp4.h      |  130
>  ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 132 insertions(+), 108 deletions(-)
>  create mode 100644 modules/demux/mp4/mp4.h
> 
> diff --git a/modules/demux/mp4/Modules.am b/modules/demux/mp4/Modules.am
> index e9fa0b7..c4d7167 100644
> --- a/modules/demux/mp4/Modules.am
> +++ b/modules/demux/mp4/Modules.am
> @@ -1,5 +1,6 @@
>  SOURCES_mp4 = \
>  	mp4.c \
> +	mp4.h \
>  	libmp4.c \
>  	libmp4.h \
>  	id3genres.h \
> diff --git a/modules/demux/mp4/mp4.c b/modules/demux/mp4/mp4.c
> index 8faba8e..cd63051 100644
> --- a/modules/demux/mp4/mp4.c
> +++ b/modules/demux/mp4/mp4.c
> @@ -28,15 +28,7 @@
>  # include "config.h"
>  #endif
>  
> -#include <vlc_common.h>
> -#include <vlc_plugin.h>
> -
> -#include <vlc_demux.h>
> -#include <vlc_charset.h>                           /* EnsureUTF8 */
> -#include <vlc_meta.h>                              /* vlc_meta_t,
> vlc_meta_ */
> -#include <vlc_input.h>

Removing so many headers cannot be right.
Removing <vlc_common.h> cannot be right.

-- 
Rémi Denis-Courmont
Sent from my collocated server