[vlc-devel] [PATCH 1/4] vlc_stream.h: add some STREAM_GET_* requests
Laurent Aimar
fenrir at elivagar.org
Wed Apr 11 20:40:41 CEST 2012
Hi,
On Wed, Apr 11, 2012 at 04:15:17PM +0200, Frédéric Yhuel wrote:
> @@ -111,6 +111,12 @@ enum stream_query_e
>
> /* XXX only data read through stream_Read/Block will be recorded */
> STREAM_SET_RECORD_STATE, /**< arg1=bool, arg2=const char *psz_ext (if arg1 is true) res=can fail */
> +
> + /* Used in Smooth Streaming */
> + STREAM_GET_TIME_SCALE, /**< arg1=uint64_t * res=cannot fail */
> + STREAM_GET_ITRACKS, /**< arg1=unsigned * (Get the number of tracks) res=cannot fail */
> + STREAM_GET_TRACK, /**< arg1=uint16_t, arg2=mp4_track_t * res=can fail */
> + STREAM_GET_FMT, /**< arg1=uint16_t, arg2=uint16_t, arg3=es_format_t * res=can fail */
I don't think that adding such mp4 private accesses to the global stream_t
API is a good idea. I am not sure how best you could avoid that, but maybe
creating an access_demux would be simpler? Or merging/moving some part
of the stream_t filter into the demuxer?
Regards,
--
fenrir
More information about the vlc-devel
mailing list