[vlc-devel] Resubmitting [PATCH] npapi plugin slave-input support. Add the ability to specify a sound source through slave-input, for example a v4l video capture device with alsa audio. Increased buffer size.

Tord Andersson tord.andersson at endian.se
Fri Apr 13 17:34:20 CEST 2012


On 2012-04-13 12.59, Sergey Radionov wrote:
> 2012/4/13 Jean-Baptiste Kempf <jb at videolan.org>:
>> On Fri, Apr 13, 2012 at 09:24:34AM +0100, Tord Andersson wrote :
>>> +    char psz_input_slave_opts[255] = "";/* input slave options */
>> How can you be sure that it will not go above 255 ?
>>
>>> +            strcat(psz_input_slave_opts, "--input-slave=");
>>> +            strncat(psz_input_slave_opts, argv[i], sizeof(psz_input_slave_opts) - strlen(psz_input_slave_opts) - 1);
>> asprintf?
> what if:
>
> else if( !strcmp( argn[i], "input-slave" ) )
> {
>     ppsz_argv[ppsz_argc++] = "--input-slave=";
>     ppsz_argv[ppsz_argc++] = argv[i];
> }
>
> will it work, how do you think?
Tested. Does not work.
>> Best regards,
>>
>> --
>> Jean-Baptiste Kempf
>> http://www.jbkempf.com/ - +33 672 704 734
>> Sent from my Electronic Device
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel




More information about the vlc-devel mailing list