[vlc-devel] Resubmitting [PATCH] npapi plugin slave-input support. Add the ability to specify a sound source through slave-input, for example a v4l video capture device with alsa audio. Increased buffer size.

[Rafaël Carré]

Le 13/04/2012 11:42, Sergey Radionov a écrit :
> 2012/4/13 Tord Andersson <tord.andersson at endian.se>:
>> On 2012-04-13 12.59, Sergey Radionov wrote:
>>> 2012/4/13 Jean-Baptiste Kempf <jb at videolan.org>:
>>>> On Fri, Apr 13, 2012 at 09:24:34AM +0100, Tord Andersson wrote :
>>>>> +    char psz_input_slave_opts[255] = "";/* input slave options */
>>>> How can you be sure that it will not go above 255 ?
>>>>
>>>>> +            strcat(psz_input_slave_opts, "--input-slave=");
>>>>> +            strncat(psz_input_slave_opts, argv[i], sizeof(psz_input_slave_opts) - strlen(psz_input_slave_opts) - 1);
>>>> asprintf?
>>> what if:
>>>
>>> else if( !strcmp( argn[i], "input-slave" ) )
>>> {
>>>     ppsz_argv[ppsz_argc++] = "--input-slave=";

Try without the '='

>>>     ppsz_argv[ppsz_argc++] = argv[i];
>>> }
>>>
>>> will it work, how do you think?
>> Tested. Does not work.
> sad. it mean that in ActiveX it will not work too. and I should fix it... ;)