[vlc-devel] [PATCH] HLS: Wait for segment to be available

Frederic YHUEL fyhuel at viotech.net
Mon Apr 16 09:53:35 CEST 2012


On Sat, Apr 14, 2012 at 3:09 PM, Frederic YHUEL <fyhuel at viotech.net> wrote:
> On Sat, Apr 14, 2012 at 2:25 AM, Tobias Güntner <fatbull at web.de> wrote:

>>> +            }
>>> +            vlc_cond_wait(&p_sys->download.wait, &p_sys->download.lock_wait);
>>> +            segment = GetSegment(s);
>>
>> All calls to GetSegment except the first are made while holding the
>> lock. Is this really correct/necessary?
>>
>
> I don't know if this is correct but this is clearly unnecessary :-)
>

Euh actually I think this is correct and necessary. I don't see why we
should hold the lock for the first call?

-- 
Frédéric



More information about the vlc-devel mailing list