[vlc-devel] [PATCH] HLS: Temporarily deactivate bandwidth adaptation

Hugo Beauzée-Luyssen beauze.h at gmail.com
Mon Apr 16 11:03:24 CEST 2012


2012/4/13 Frédéric Yhuel <fyhuel at viotech.net>:
> Without support for resolution switch, bandwidth adaptation should not
> be activated by default, IMHO. For the end user, being stuck with the
> lowest bitrate seems better than VLC dying in atrocious suffering.
> ---
>  modules/stream_filter/httplive.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/modules/stream_filter/httplive.c b/modules/stream_filter/httplive.c
> index 3e956a7..b72d6ad 100644
> --- a/modules/stream_filter/httplive.c
> +++ b/modules/stream_filter/httplive.c
> @@ -1496,6 +1496,9 @@ static int hls_DownloadSegmentData(stream_t *s, hls_stream_t *hls, segment_t *se
>
>     uint64_t bw = segment->size * 8 * 1000000 / __MAX(1, duration); /* bits / s */
>     p_sys->bandwidth = bw;
> +    /* We temporarily deactivate bandwidth adaptation until resolution
> +     * switch is supported */
> +#if 0
>     if (p_sys->b_meta && (hls->bandwidth != bw))
>     {
>         int newstream = BandwidthAdaptation(s, hls->id, &bw);
> @@ -1508,6 +1511,7 @@ static int hls_DownloadSegmentData(stream_t *s, hls_stream_t *hls, segment_t *se
>             *cur_stream = newstream;
>         }
>     }
> +#endif
>     return VLC_SUCCESS;
>  }
>
> --
> 1.7.5.4
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel

Although I don't like this, I have to admit it seems like a good idea for now :(

Regards,

-- 
Hugo Beauzée-Luyssen



More information about the vlc-devel mailing list