[vlc-devel] [PATCH/RFC] libswresample based audio resampler.
aballier at gentoo.org
Mon Apr 16 20:09:45 CEST 2012
On Mon, 16 Apr 2012 18:39:52 +0300
"Rémi Denis-Courmont" <remi at remlab.net> wrote:
> Le lundi 16 avril 2012 16:46:13 Alexis Ballier, vous avez écrit :
> > On Sun, 15 Apr 2012 18:48:42 +0300
> > "Rémi Denis-Courmont" <remi at remlab.net> wrote:
> > > Try
> > > changing the playback rate on the fly.
> > This didnt work. I didnt think this could change after Open();
> > fixed and new patch enclosed, though probably more cpu intensive
> > since i imagine swr_init does some precalculations.
> You can't reinitialize the resampler all the time. Not only is it
> slow, it will probably cause glitches.
yes this should be done only if parameters changed. however, even like
that i didnt experience glitches, and is imho simpler for testing at
first. point taken anyway, next rev will take this into account.
> And I still don't see how you can upsample with that memory
> allocation scheme of yours.
you're probably right, i'll have a look at it, i suppose i havent been
able to trigger real upsampling; i've seen some upsampling but with
very close samplerate, so probably doesnt count.
it'll be next week though.
More information about the vlc-devel