[vlc-devel] [PATCH] x264: support setting any option

[Ilkka Ollakka]

On Mon, Apr 16, 2012 at 12:43:57PM -0400, Rafaël Carré wrote:
> ---
>  modules/codec/x264.c |   31 ++++++++++++++++++++++++++++++-
>  1 file changed, 30 insertions(+), 1 deletion(-)

> diff --git a/modules/codec/x264.c b/modules/codec/x264.c
> index c09f8fe..4de9f56 100644
> --- a/modules/codec/x264.c
> +++ b/modules/codec/x264.c
> @@ -407,6 +407,9 @@ static void x264_log( void *, int i_level, const char *psz, va_list );
>  #define TUNE_TEXT N_("Default tune setting used" )
>  #define PRESET_TEXT N_("Default preset setting used" )

> +#define X264_OPTIONS_TEXT N_("x264 private options.")
> +#define X264_OPTIONS_LONGTEXT N_("x264 private options, in the form {opt=val,op2=val2} .")
> +

Maybe better wording would be talk about advanced options, and deprecate
advanced options in favor of that options string.

-- 
Ilkka Ollakka
Committees have become so important nowadays that subcommittees have to
be appointed to do the work.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120417/60d3196d/attachment.sig>