[vlc-devel] [PATCH] correct ARM assembly to compile with Apple gas

David Geldreich david.geldreich at free.fr
Thu Apr 19 23:04:35 CEST 2012


With the help of feepk, we managed to make VLC iOS build the arm_neon
assembly files.

Unfortunately, some of them give compilation errors. Here is a fix for
these simple errors.

arm_neon .S files were using PLD uppercase but Apple gas only accept lowercase
instructions

Regards.

David
---
 modules/arm_neon/i420_rgb.S |    8 ++++----
 modules/arm_neon/nv12_rgb.S |    6 +++---
 modules/arm_neon/nv21_rgb.S |    6 +++---
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/modules/arm_neon/i420_rgb.S b/modules/arm_neon/i420_rgb.S
index cc0caf3..1e9600e 100644
--- a/modules/arm_neon/i420_rgb.S
+++ b/modules/arm_neon/i420_rgb.S
@@ -131,8 +131,8 @@ loop_col:
 	vsub.s16	chro_g, Gc, chro_g
 	vadd.s16	chro_b, Bc, chro_b
 
-	PLD	[U]
-	PLD	[V]
+	pld	[U]
+	pld	[V]
 
 	/* Y Top Row */
 	vld2.u8	{y1,y2}, [Y1,:128]!
@@ -155,7 +155,7 @@ loop_col:
 	vqrshrun.s16	green2, green, #6
 	vqrshrun.s16	blue2, blue, #6
 
-	PLD	[Y1]
+	pld	[Y1]
 
 	vmov.u8	alpha2, #255
 	vzip.u8	red1, red2
@@ -186,7 +186,7 @@ loop_col:
 	vqrshrun.s16	green2, green, #6
 	vqrshrun.s16	blue2, blue, #6
 
-	PLD	[Y2]
+	pld	[Y2]
 
 	vmov.u8	alpha2, #255
 	vzip.u8	red1, red2
diff --git a/modules/arm_neon/nv12_rgb.S b/modules/arm_neon/nv12_rgb.S
index f4bb510..64a2d76 100644
--- a/modules/arm_neon/nv12_rgb.S
+++ b/modules/arm_neon/nv12_rgb.S
@@ -130,7 +130,7 @@ loop_col:
 	vsub.s16	chro_g, Gc, chro_g
 	vadd.s16	chro_b, Bc, chro_b
 
-	PLD	[U]
+	pld	[U]
 
 	/* Y Top Row */
 	vld2.u8	{y1,y2}, [Y1,:128]!
@@ -153,7 +153,7 @@ loop_col:
 	vqrshrun.s16	green2, green, #6
 	vqrshrun.s16	blue2, blue, #6
 
-	PLD	[Y1]
+	pld	[Y1]
 
 	vmov.u8	alpha2, #255
 	vzip.u8	red1, red2
@@ -184,7 +184,7 @@ loop_col:
 	vqrshrun.s16	green2, green, #6
 	vqrshrun.s16	blue2, blue, #6
 
-	PLD	[Y2]
+	pld	[Y2]
 
 	vmov.u8	alpha2, #255
 	vzip.u8	red1, red2
diff --git a/modules/arm_neon/nv21_rgb.S b/modules/arm_neon/nv21_rgb.S
index 82a7099..b7f9745 100644
--- a/modules/arm_neon/nv21_rgb.S
+++ b/modules/arm_neon/nv21_rgb.S
@@ -130,7 +130,7 @@ loop_col:
 	vsub.s16	chro_g, Gc, chro_g
 	vadd.s16	chro_b, Bc, chro_b
 
-	PLD	[U]
+	pld	[U]
 
 	/* Y Top Row */
 	vld2.u8	{y1,y2}, [Y1,:128]!
@@ -153,7 +153,7 @@ loop_col:
 	vqrshrun.s16	green2, green, #6
 	vqrshrun.s16	blue2, blue, #6
 
-	PLD	[Y1]
+	pld	[Y1]
 
 	vmov.u8	alpha2, #255
 	vzip.u8	red1, red2
@@ -184,7 +184,7 @@ loop_col:
 	vqrshrun.s16	green2, green, #6
 	vqrshrun.s16	blue2, blue, #6
 
-	PLD	[Y2]
+	pld	[Y2]
 
 	vmov.u8	alpha2, #255
 	vzip.u8	red1, red2
-- 
1.7.7.5 (Apple Git-26)




More information about the vlc-devel mailing list