[vlc-devel] [PATCH] define/use a function macro to handle the underscore prefix for some ARM ABI

[David Geldreich]

Hello Rafaël,

Le 20 avr. 2012 à 18:30, Rafaël Carré a écrit :

> Le 2012-04-20 10:41, David Geldreich a écrit :
>> This correct a compilation/link problem of arm_neon plugins on iOS
>> 
>> inspired but the asm.S from ffmpeg, we define a "function" macro
>> EXTERN_ASM is hardcoded for iOS vs Android case.
> 
> There is more than iOS an Android which ARM code (e.g. Linux)

Yes, the underscore usage in the ABI should be tested by configure.

Today, in current VLC code, it is "hardcoded" for ABI without the underscore (which I mistakenly called the "Android case")
So waiting for the corresponding autoconf test, I added a "#idef __APPLE__" case.

My second patch proposal is using only a gcc extension, so no need to add test in configure. But, then the code will depend on this compiler extension.

My final goal is to integrate a Neon version of channel_mixer I proposed on 4/4/2012 in arm_neon. I only have iOS devices to test. So, we worked with feepk for modules/arm_neon to compile for iOS. Now, we have this link/symbol issue which is not specific to iOS.

Regards.