[vlc-devel] [PATCH] define/use a function macro to handle the underscore prefix for some ARM ABI

[David Geldreich]

Hello Remi,

Le 20 avr. 2012 à 19:58, Rémi Denis-Courmont a écrit :

> Le vendredi 20 avril 2012 19:50:57 David Geldreich, vous avez écrit :
>> Yes, the underscore usage in the ABI should be tested by configure.
> 
> Oh gosh, please don't. We have enough non-portable "portability" hacks and 
> fruity ifdefs already.

Testing the ABI in configure is not a hack, that's what ffmpeg do. But this is your right to be against it.

I have made multiple proposals.

Your only proposals are :
- "don't use assembly macros I don't understand"
- "don't add a test to autoconf"
- "don't modify my code"

So the only thing you are not opposed to is using the gcc extension ?

I am trying to help, but I do not have your experience with VLC, I don't know all the compilers you are targeting, all the OS/ARM platform the arm_neon module is supposed to work on.

Please try make a constructive comment.

Regards.