[vlc-devel] [PATCH 6/7] On Windows systems playing items like dvd:// or screen:// causes strange shortcuts in the user recently used folder.

[Rafaël Carré]

Hello,

Le 2012-04-22 16:38, VlcVelope a écrit :
                     ^^^^^^^^^
Can you resend with your real name please?

> See http://social.technet.microsoft.com/Forums/nb-NO/w7itprogeneral/thread/02a71215-e308-408c-94a6-81f5a8e564a6
> for some information. The solution calls SHAddToRecentDocs only if make_path
> returns a valid path.
> ---
>  modules/gui/qt4/recents.cpp |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>  mode change 100644 => 100755 modules/gui/qt4/recents.cpp
> 
> diff --git a/modules/gui/qt4/recents.cpp b/modules/gui/qt4/recents.cpp
> old mode 100644
> new mode 100755
> index b07e796..5f97374
> --- a/modules/gui/qt4/recents.cpp
> +++ b/modules/gui/qt4/recents.cpp
> @@ -88,7 +88,9 @@ void RecentsMRL::addRecent( const QString &mrl )
>  
>  #ifdef WIN32
>      /* Add to the Windows 7 default list in taskbar */
> -    SHAddToRecentDocs( SHARD_PATHW, qtu( mrl ) );
> +    char* path = make_path( qtu( mrl ) );

You should free path after using it.

> +    if( path )
> +        SHAddToRecentDocs( SHARD_PATHW, path );
>  #endif
>  
>      int i_index = stack->indexOf( mrl );


Else, patch is OK