[vlc-devel] [PATCH 4/7] Enabled the Qt4-PictureFlow (fixed bugs when PL/ML was changed)

[Jean-Baptiste Kempf]

On Mon, Apr 23, 2012 at 11:58:04PM +0200, VlcVelope wrote :
> On 22.04.2012 22:53, Jean-Baptiste Kempf wrote:
> >On Sun, Apr 22, 2012 at 10:38:13PM +0200, VlcVelope wrote :
> >>  mode change 100644 =>  100755 modules/gui/qt4/components/playlist/standardpanel.cpp
> >>  mode change 100644 =>  100755 modules/gui/qt4/components/playlist/views.cpp
> >>  mode change 100644 =>  100755 modules/gui/qt4/components/playlist/views.hpp
> >>  mode change 100644 =>  100755 modules/gui/qt4/util/pictureflow.cpp
> >>  mode change 100644 =>  100755 modules/gui/qt4/util/pictureflow.hpp
> >
> >No.
> 
> What do you mean with "No."? I am starting to use git right now and
> I do not understand.

You changed the chmod of those files.

> You mean the #ifndef will stay for some time?

Indeed, at least, for a start.

> When I was working on that, PictureFlow was crashing if the model
> was not ready set. So I rebuilt the model before setting it (for any
> view)

This does not crash the other views, so I do not think this is good.
This particular area is quite sensitive to changes to be honest.

> I think it was an issue when you change from PL to ML during
> playback the selection in the view was wrong. I will check this.

Cool.

> >What is this change for?
> Well, qRgba translates to 0, and the width/height I thought most art
> will be more 4:3 (in this case 5:4) than 3:4. The real size is set
> by the mis-tabbed statement above.

Yes, but qRgba can be defined in the old way.
About the height, isn't the text in it too?

> >No tabs, please.
> >
> >>+    d->state->model=(VLCModel*)model;
> >?
> PictureFlowState::model is of VLCModel*.

Sure, but I doubt the code is correct.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device