[vlc-devel] [PATCH] Add Smooth Streaming module

[Tobias Güntner]

Hello!

Am 24.04.2012 15:35, schrieb Frederic YHUEL:
>>>> +    if( strstr( (const char*)peek, needle ) != NULL )
>>
>> What if peek contains no '\0' and the needle is not in there?
>>
>
> Then it returns false... am I missing something?

strstr will dutifully continue past the end of the buffer until it finds 
the needle or a terminating '\0' or causes a segfault.

>>>> +        conv_peek = FromCharset( "UTF-16", peek, 1024 );
>>
>> Little or big endian?
>>
>
> What should I do?

I think you should look for a Byte Order Mark and use UTF-16LE or 
UTF-16BE instead if you find one. Like stream_ReadLine.

>> Correct me if I'm wrong, but doesn't VLC cache 1000ms worth of data
>> before starting playback, assuming the default network-caching setting?
>
> What does mean 1000ms worth of data?

Well ... What I tried to say: If I understand correctly, VLC buffers a 
stream until it has enough data for a few 100 ms of playback. This could 
be several 100 kB. IMHO it does not matter whether you peek 512 or 1024 
bytes unless the available bandwidth is very, very, very, *very* low. 
And in that case there are probably bigger problems to worry about than 
a slightly increased delay somewhere. :)

Regards,
Tobias