[vlc-devel] [PATCH 3/3] Add file dialogue to manually set album art.

[Jean-Baptiste Kempf]

On Tue, Jul 31, 2012 at 02:34:04PM +0200, Angelo Haller wrote :
> +    CONNECT( THEMIM->getIM(), artChanged( QString ), this, enterEditMode() );

This seems dubious, like very dubious.

> +    QString filePath = QFileDialog::getOpenFileName( this, qtr( "Choose Image" ),
> +        p_intf->p_sys->filepath, qtr( "Image Files (*.gif *.jpg *.jpeg *.png)" ) );

Are you sure about the qtr use here?

> +        if( old_url.startsWith( QString::fromUtf8( psz_cachedir ) ) )
> +            QFile( old_url ).remove(); /* Purge cached artwork */

Not leaking anythin here ?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device