[vlc-devel] [PATCH 1/7] opencv_wrapper: Port to video filter2
Rémi Denis-Courmont
remi at remlab.net
Thu Aug 9 23:17:48 CEST 2012
Le jeudi 9 août 2012 22:55:28 Edward Wang, vous avez écrit :
> On 12-08-09 03:52 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> > Le jeudi 9 août 2012 22:51:15 Edward Wang, vous avez écrit :
> >> On 12-08-09 03:49 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> >>> This patch ignores most of my earlier review comments without
> >>> justification.
> >>
> >> How so?
> >
> > How *not* so?
>
> The only not-so part is "I don't see why a VLC filter object would be
> needed with another VLC filter
> object" and my answer would be that it was like that before this patch.
That answer was not provided before or within the second patch series.
Reviewing patches is not anywhere near fun. This behaviour is annoying.
--
Rémi Denis-Courmont
http://www.linkedin.com/in/remidenis
More information about the vlc-devel
mailing list