[vlc-devel] [PATCH] opencv_wrapper: Kill a warning

Rémi Denis-Courmont remi at remlab.net
Sun Aug 12 10:10:32 CEST 2012


Le dimanche 12 août 2012 02:17:45 Edward Wang, vous avez écrit :
> ---
>  modules/video_filter/opencv_wrapper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/modules/video_filter/opencv_wrapper.c
> b/modules/video_filter/opencv_wrapper.c index ed535e2..1227353 100644
> --- a/modules/video_filter/opencv_wrapper.c
> +++ b/modules/video_filter/opencv_wrapper.c
> @@ -421,7 +421,7 @@ static picture_t* Filter( filter_t* p_filter,
> picture_t* p_pic ) VlcPictureToIplImage( p_filter, p_pic );
>      // Pass the image (as a pointer to the first IplImage*) to the
>      // internal OpenCV filter for processing.
> -    p_filter->p_sys->p_opencv->pf_video_filter( p_filter->p_sys->p_opencv,
> &(p_filter->p_sys->p_cv_image[0]) ); +   
> p_filter->p_sys->p_opencv->pf_video_filter( p_filter->p_sys->p_opencv,
> (picture_t*)&(p_filter->p_sys->p_cv_image[0]) );

This _cannot_ be right.

Only a picture_t can be a picture_t, or a void in rare circumstances. Either 
way there would be no warnings.

-- 
Rémi Denis-Courmont
http://www.linkedin.com/in/remidenis



More information about the vlc-devel mailing list