[vlc-devel] [PATCH] http: Set the seekable flag when a Content-Range header is parsed

[Rémi Denis-Courmont]

Le dimanche 12 août 2012 15:02:24 Martin Storsjö, vous avez écrit :
> ES File Explorer (a file browser on Android, that can read files
> over SMB and provide them to other applications on the device via
> a built in HTTP server) replies with "HTTP/1.1 200 OK" on the first
> request (where the request included "Range: bytes=0-") instead of
> "HTTP/1.1 206 Partial Content", and without any
> "Accept-Ranges: bytes" header. It does set a
> "Content-Range: bytes 0-xxx/yyy" header and does support seeking
> just fine though, so identify it as seekable.

The Content-Range header does not imply that the content is seekable. It only 
specifies the content total length (as opposed to Content-Length), if known.
*Only* the code 206 does imply seekability. That is why VLC explicitly sends a 
"Range: 0-" header explicitly.

This patch will break interoperability with conformant HTTP servers that 
cannot seek, and HTTP proxies. Thus this patch has to be rejected.

Please go bug the clueless ES File Explorer programmers instead.

-- 
Rémi Denis-Courmont
C/C++ software engineer looking for a job
http://www.linkedin.com/in/remidenis