[vlc-devel] [PATCH 1/2] Add new API to libvlc for persistent equalizer settings.

[Mark Lee]

On 12 August 2012 13:32, Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le dimanche 12 août 2012 12:07:57 Mark Lee, vous avez écrit :
> > > > +    var_AddCallback (p_parent, "equalizer-preamp", var_Copy, aout );
> > > > +    var_AddCallback (p_parent, "equalizer-bands", var_Copy, aout );
> > > > +
> > >
> > > You need to ensure the aout variables exist, and initialized, to do
> that.
> > >
> > > OK, this is the only comment I'm not sure about. I have seen in
> >
> > equalizer.c that it creates those variables on the aout, but of course
> the
> > equalizer may not be enabled yet. Am I OK to simply create and initialise
> > those variables in the same place I register the callbacks?
>
> I don't know, probably. It depends on assumption made or not made within
> the
> VLC code base.
>
> > Or will that interfere with what equalizer.c is doing?
>
> That's one of the potential issues.
>
>
Thanks, I think I have a solution for this. We'll see if it's acceptable
soon.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120812/a22cba63/attachment.html>