[vlc-devel] [vlc-commits] wasapi: provide user-friendly audio endpoint name (fixes #7201)

Rafaël Carré funman at videolan.org
Mon Aug 13 11:09:56 CEST 2012

Sorry but this is not acceptable, thus this commit is rejected.

Broken code should not be committed, especially when you knew it
perfectly beforehand.

That code might be desired and even perfectly valid according to
Microsoft and MSDN, but since it can not be built with free software it
doesn't belong as-is in VLC repository.

Add back the original "#ifdef FIXED" or revert this commit.

Le 2012-08-11 21:55, Rémi Denis-Courmont a écrit :
> Just FYI, the buildbots seem to have incomplete WASAPI headers.
> Le samedi 11 août 2012 22:41:56 Rémi Denis-Courmont, vous avez écrit :
>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Aug 11
>> 22:40:50 2012 +0300| [f03a60731299da6d37063be3039e19d2fc7261a9] |
>> committer: Rémi Denis-Courmont
>> wasapi: provide user-friendly audio endpoint name (fixes #7201)
>> Also list the entries in the log like ALSA output.

More information about the vlc-devel mailing list