[vlc-devel] [PATCH 3/3] Add file dialogue to manually set album art.

[Jean-Baptiste Kempf]

On Sun, Aug 12, 2012 at 03:41:48PM +0200, Angelo Haller wrote :
> On 08/10/2012 06:36 PM, Jean-Baptiste Kempf wrote:
> >On Fri, Aug 10, 2012 at 05:42:42PM +0200, Angelo Haller wrote :
> >>Well... yeah it might be confusing although I think this would be
> >>good behaviour.
> >How so? You should be able to save the artwork only if you changed it,
> >no?
> 
> I personally think that it would be great to save the auto-fetched
> artwork too.

OK.
We will need to refine this with a UI scheme.

> >>>The return of QString::fromUtf8 I meant.
> >>This is actually an interesting question. What encoding is used for
> >>URLs and file paths in vlc?
> >No, utf-8 is the right thing. But what I say is that you probably need
> >to check if all allocated QString are freed in the end.
> 
> The QStrings should handle the memory management themselves.

Probably my mistake reading your code, then. But you should use qfu when
applicable.

Patch is good for me.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device