[vlc-devel] [PATCH] macosx: Declare MainWindow private methods in a category.
brendonjustin at gmail.com
Thu Aug 16 17:16:06 CEST 2012
On Thursday, August 16, 2012 at 6:00 AM, vlc-devel-request at videolan.org wrote:
> Thanks for the patch!
> On 16.08.2012, at 03:34, Brendon Justin <brendonjustin at gmail.com (mailto:brendonjustin at gmail.com)> wrote:
> > +- (IBAction)prev:(id)sender;
> > +- (IBAction)backward:(id)sender;
> > +- (IBAction)next:(id)sender;
> > +- (IBAction)forward:(id)sender;
> These don't belong here but in MainWindow.h to ensure compatibility with Xcode 3.2's interface builder. Support for IBActions in categories was added in Xcode 4.2 as far as I remember.
> Btw. Which compiler is so picky about this? Obj-C tolerates private methods without previous declaration just fine, since the dynamic lookup doesn't care about declarations, but about actually implemented methods only.
> Best regards,
A handful of functions were used before they were declared, I think the add/removeJumpButtons and add/removePlaymodeButtons functions. Most of the functions were not used before their definitions and did not cause warnings though. I thought that doing all of the undeclared functions would be better than just the ones that caused warnings, thus the long list.
I'll resend the patch with the IBActions moved to the header file in a bit.
As an aside, having different methods named fwd: and forward: (and bwd: and backward:) can't be good for clarity.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel