[vlc-devel] [PATCHES] contrib: libpostproc, libcaca, bghudappkit, growl

[Felix Paul Kühne]

Hey,

thanks for the feedback!

On 19.08.2012, at 19:49, Rafaël Carré wrote:

>> 1) adds 2 missing includes to libpostproc, since it fails to find the defines properly when combined with recent libavutil. This should have no negative impact when using existing libavutil versions.
> 
> Did you send this to postproc mailing list?
Not yet. I'll do so later on.

>> 2) disables some inlines assembly in libcaca which isn't supported by llvm-gcc or clang. GCC-4.2 is no longer part of recent Xcode release, so switching the compiler isn't an option here.
> 
> I prefer if there is a #ifdef __llvm__ or something
Sure, no problem.

>> 4) idem for growl as well as some cleanup.
> 
> $(MOVE) should not be at the end?

well, I can do that. I'd just need to slightly edit the sed line, so no problem at all.


Best regards,

Felix