[vlc-devel] [PATCH] Qt: Add Anaglyph 3D video filter to effects dialog.

[Rémi Denis-Courmont]

Le jeudi 23 août 2012 16:01:24 Zoran Turalija, vous avez écrit :
> Add new option in Tools/Effects and Filters/Video Effects/Advanced dialog
> to toggle on/off Anaglyph 3D video filter.
> ---
>  modules/gui/macosx/VideoEffects.m              |    2 ++

Does not look like Qt4 to me. You should probably split the patch.

>  modules/gui/qt4/components/extended_panels.cpp |    5 ++++-
>  modules/gui/qt4/ui/video_effects.ui            |    7 +++++++
>  3 files changed, 13 insertions(+), 1 deletions(-)
> 
> diff --git a/modules/gui/macosx/VideoEffects.m
> b/modules/gui/macosx/VideoEffects.m index 624a748..482aaf1 100644
> --- a/modules/gui/macosx/VideoEffects.m
> +++ b/modules/gui/macosx/VideoEffects.m
> @@ -140,6 +140,7 @@ static VLCVideoEffects *_o_sharedInstance = nil;
>      [o_watereffect_ckb setTitle:_NS("Water effect")];
>      [o_waves_ckb setTitle:_NS("Waves")];
>      [o_psychedelic_ckb setTitle:_NS("Psychedelic")];
> +    [o_anaglyph_ckb setTitle:_NS("Anaglyph 3D")];
> 
>      [o_addtext_ckb setTitle:_NS("Add text")];
>      [o_addtext_text_lbl setStringValue:_NS("Text")];
> @@ -221,6 +222,7 @@ static VLCVideoEffects *_o_sharedInstance = nil;
>          [o_watereffect_ckb setState: (NSInteger)strstr( psz_vfilters,
> "ripple")]; [o_waves_ckb setState: (NSInteger)strstr( psz_vfilters,
> "wave")]; [o_psychedelic_ckb setState: (NSInteger)strstr( psz_vfilters,
> "psychedelic")]; +        [o_anaglyph_ckb setState: (NSInteger)strstr(
> psz_vfilters, "anaglyph")]; free( psz_vfilters );
>      }
>      psz_vfilters = config_GetPsz( p_intf, "sub-source" );
> diff --git a/modules/gui/qt4/components/extended_panels.cpp
> b/modules/gui/qt4/components/extended_panels.cpp index 719318c..6dda355
> 100644
> --- a/modules/gui/qt4/components/extended_panels.cpp
> +++ b/modules/gui/qt4/components/extended_panels.cpp
> @@ -247,6 +247,8 @@ ExtVideo::ExtVideo( intf_thread_t *_p_intf, QTabWidget
> *_parent ) : _parent->removeTab( _parent->indexOf( ui.tab_atmo ) );
>      }
> 
> +    SETUP_VFILTER( anaglyph )
> +
>  #undef SETUP_VFILTER
>  #undef SETUP_VFILTER_OPTION
> 
> @@ -685,7 +687,8 @@ void ExtVideo::gotoConf( QObject* src )
>      SHOWCONF( "puzzle" );
>      SHOWCONF( "wall" );
>      SHOWCONF( "gradient" );
> -    SHOWCONF( "colorthres" )
> +    SHOWCONF( "colorthres" );
> +    SHOWCONF( "anaglyph" )
>  }
>  #endif
> 
> diff --git a/modules/gui/qt4/ui/video_effects.ui
> b/modules/gui/qt4/ui/video_effects.ui index d69381f..2d21e43 100644
> --- a/modules/gui/qt4/ui/video_effects.ui
> +++ b/modules/gui/qt4/ui/video_effects.ui
> @@ -1785,6 +1785,13 @@
>        </property>
>       </widget>
>      </item>
> +    <item row="8" column="2">
> +     <widget class="QCheckBox" name="anaglyphEnable">
> +      <property name="text">
> +       <string>Anaglyph 3D</string>
> +      </property>
> +     </widget>
> +    </item>
>     </layout>
>    </widget>
>   </widget>


-- 
Rémi Denis-Courmont
C/C++ software engineer looking for a job
http://www.linkedin.com/in/remidenis