[vlc-devel] [PATCH 1/3] OS/2: Include sys/types.h in vlc_common.h

KO Myung-Hun komh78 at gmail.com
Sat Aug 25 05:39:11 CEST 2012

Rémi Denis-Courmont wrote:
> Le vendredi 24 août 2012 17:45:15 KO Myung-Hun, vous avez écrit :
>>>> +#ifdef __OS2__
>>>> +#   include <sys/types.h>
>>>> +#endif
>>> This should be included unconditionally, or if ssize_t is used
>>> conditionally, under the same condition.
>> Ok, include unconditionally.
> Well, I don't mind elevating <sys/types.h> to the same rank of as <inttypes.h> 
> and <stdbool.h>. But then all the redundant inclusions should probably be 
> removed from the code base...

Instead, include it in vlc_configuration.h which are using ssize_t directly.

KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.18 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-OS-2-Include-sys-types.h-in-vlc_configuration.h.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120825/ea185c00/attachment.ksh>

More information about the vlc-devel mailing list