[vlc-devel] [vlc-commits] macosx: only scan optical devices paths once and cache the result

[David Fuhrmann]

Am 25.08.2012 um 01:03 schrieb Felix Paul Kühne <fkuehne.videolan at gmail.com>:

> Hi David,
> 
> On 25.08.2012, at 00:45, David Fuhrmann <git at videolan.org> wrote:
> 
>> vlc | branch: master | David Fuhrmann <david.fuhrmann at googlemail.com> | Fri Aug 24 23:44:37 2012 +0200| [fe17d4409a2a6cd818981c0137729ba7344d1fcf] | committer: David Fuhrmann
>> 
>> macosx: only scan optical devices paths once and cache the result
> 
> Nice!
> 
> One minor remark: o_opticalDevices probably doesn't need to mutable, since it only got a single write operation, which it is emptied and re-filled. Mutable arrays are noticeably bigger in memory and quite a bit slower, so it is reasonable to use read-only arrays as much as possible.

Good point. I will change that later.

Greetings,
David