[vlc-devel] [PATCH] auhal setMute (refs #7329)

Rémi Denis-Courmont rem at videolan.org
Sun Aug 26 18:12:48 CEST 2012


On Sunday 26 August 2012, Felix Paul Kühne wrote:
> On 26.08.2012, at 17:19, "Rémi Denis-Courmont" <remi at remlab.net> wrote:
> >   Hello,
> > 
> > On Sunday 26 August 2012, Felix Paul Kühne wrote:
> >> Well, it appears that the core no longer maintains the volume control
> >> (see my patches, if you like).
> >> 
> >> Thus, every audio output needs to implement it itself as well as every
> >> interface module. Sounds silly, adds lots of duplicated code and
> >> work-arounds,
> > 
> > You know, this is insulting.
> No, this is about the code level, not about you, your person or any of your
> character's or body's qualities or characteristics. I didn't even say that
> your work was BS.

Not explicitly but...

> Additionally, please note the subjunctive used in my
> wording.

I don't see subjunctive in "[it] adds lots of duplicated code and work-

> Regrettably, ranting on this list seems to be the only way to get any
> response from you, which is a shame.

This is a gross misrepresentation. You did not ask *me* anything. You just 
assigned me two bugs that actually belong in the CoreAudio plugin.

I did not exhibit any activity on git, Trac, IRC or the ML; I was obviously 
absent. In fact I was flying to a conference on *VideoLAN* sponsorship. So, 
sorry but I am a normal individual: I do not have satellite Internet and I am 
not always available within 48 hours notice.

However, my commit logs are on average the longest of all key developers. Last 
time I checked, I also held the largest comments to code ratio (source: 
Ohloh). You might not be bothered to read those comments, but that is your 
problem, not mine.

If you thought some documentation was unclear, you were welcome to reply to 
the commit log, or file a bug against the Documentation component, or whatever. 
I don't recall of any such occurence.

> I'd love to know the rationale behind
> these changes to the volume mechanism to see the benefits for both the
> developer and the user in contrast to the existing 2.0 implementation. So
> far, I only see bloat and missing functionality, which is typically what
> you try to avoid and to remove wherever possible, so obviously I don't
> understand your work.

Where do you actually see duplication?
Where do you actually see bloat?

There is identical logic for software volume outputs (ALSA, JACK, KAI and 
conditionally WaveOut). Because it is identical, it is factored (in volume.h). 
So I really wonder where you saw duplicated code.

As for bloat, the core for UI volume handling has become smaller and simpler. 
Compare the sizes of src/audio_output/intf.c if you don't believe it... So 
again, I doubt you actually saw what you claim to see.

Rémi Denis-Courmont

More information about the vlc-devel mailing list