[vlc-devel] [PATCH] swscale: Fix pixel format for VLC_CODEC_RGBA

[Rémi Denis-Courmont]

On Thu, 20 Dec 2012 14:43:03 +0100, Laurent Aimar <fenrir at elivagar.org>
wrote:
>> Hi,
>> 
>> this patch resolves inverted reds and blues during XCB screen capture
of
>> a semi-transparent window.
>> The issue was introduced by commit
>> fb7f014161f68c914e028adbea68b7ee9863c76e, which changed the pixel
format
>> from PIX_FMT_RGBA32 to PIX_FMT_BGR32.
>  I am not sure that it is right. I fear that the issue is in the XCB
module
> that declares RGBA but returns data that does not follow the order that
> VLC RGBA wants (RGBA is only supported with a fixed order in VLC).

That might be. I never tried ARGB capture. But I don't know what order VLC
wants, and whether it depends on the endianess?

(In fact, I would much rather use different RGB chroma identifiers for
different RGB masks. Luckily, RGBA does not use RGB masks.)

-- 
Rémi Denis-Courmont
Sent from my collocated server