[vlc-devel] [PATCH] chromaprint: add fingerprinter module

[Rémi Denis-Courmont]

Le jeudi 20 décembre 2012 22:59:21, Francois Cartegnie a écrit :
> Le 20/12/2012 16:21, Rafaël Carré a écrit :
> > Basically you're implementing sleep() in a more confusing way.
> > condition variable would be useful if another thread signals this one
> > that it doesn't need to wait any more.
> 
> Yes, but using *sleep() throws use warnings.
> 
> As this kind of waiting (without cond trigger) was already in use in
> auhal.c, i used it too...

Not to mention that code prefixed with FIXME rarely makes for a good example, 
that is not even true:

auhal.c calls vlc_cond_signal() on its condition variable, verifies a predicate 
and protects its evaluation with the associated mutex.

-- 
Rémi Denis-Courmont
http://www.remlab.net/