[vlc-devel] [vlc-commits] format: add missing conversions between U8, S16N, FL32, S32N and FL64

[Rafaël Carré]

Le 25/12/2012 14:38, Rafaël Carré a écrit :
> Le 21/12/2012 19:35, Rémi Denis-Courmont a écrit :
>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri Dec 21 20:33:45 2012 +0200| [2c22b194c8c6c7c134db7eb35c9feef81f5fec4b] | committer: Rémi Denis-Courmont
>>
>> format: add missing conversions between U8, S16N, FL32, S32N and FL64
>>
>> And simplify accordingly.
>>
>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2c22b194c8c6c7c134db7eb35c9feef81f5fec4b
>> ---
>>
>>  modules/audio_filter/Modules.am         |    4 +-
>>  modules/audio_filter/converter/format.c |  485 ++++++++++++++++++++-----------
>>  2 files changed, 312 insertions(+), 177 deletions(-)
>>
>> Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=2c22b194c8c6c7c134db7eb35c9feef81f5fec4b
> 
> -            out->i_nb_samples = block->i_nb_samples;
> 
> This removal silently breaks simple channel downmixer and probably a
> number of audio filters, so this raises several problems:

-            out->i_dts        = block->i_dts;

Also breaks synchronisation:

[0x58dbf83c]: main audio output playback way too late (293519879178):
flushing buffers

I guess these properties should be copied by the code running the
filters, but I don't know which properties can be changed by filters.