[vlc-devel] [PATCH 07/11] Make sure font color attribute is quoted.

Devin Heitmueller dheitmueller at kernellabs.com
Thu Dec 27 07:08:19 CET 2012


We need to add quotes to the color attribute for the font tag, or else
the XML parser will choke and the HTML will not be rendered.
---
 modules/codec/cc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/codec/cc.c b/modules/codec/cc.c
index ef788ca..d9fba54 100644
--- a/modules/codec/cc.c
+++ b/modules/codec/cc.c
@@ -1004,9 +1004,9 @@ static void Eia608TextLine( struct eia608_screen *screen, char *psz_text, int i_
                     "#ff00ff",  // magenta
                     "#ffffff",  // user defined XXX we use white
                 };
-                CAT( "<font color=" );
+                CAT( "<font color=\"" );
                 CAT( ppsz_color[color] );
-                CAT( ">" );
+                CAT( "\">" );
             }
             if( ( b_close_italics && b_italics ) || ( b_italics && !b_last_italics ) )
                 CAT( "<i>" );
-- 
1.7.9.5




More information about the vlc-devel mailing list