[vlc-devel] [PATCH 00/11] EIA-608 closed captions rendering improvements

Rafaël Carré funman at videolan.org
Sun Dec 30 00:34:02 CET 2012


Le 27/12/2012 07:08, Devin Heitmueller a écrit :
> This patch series contains a bunch of improvements to the rendering of
> EIA-608 closed captions.  This includes fixes to provide consistent
> placement of captions, various bug fixes for edge cases, and code to
> make styles/colors work as would be expected.
> This patch series will be followed with a more invasive patch which
> renders a black background under the text to improve readability.
> Validated using the WGBH closed captioning test stream.
> This was was sponsored by GetWellNetwork Inc.
> Devin Heitmueller (11):
>   Enable HTML renderer for closed captions
>   Render all rows, even blank ones
>   Fix positioning so that the EIA-608 field is properly centered
>   Convert leading whitespace characters to non-breaking spaces
>   Fix rendering of HTML reserved characters
>   Increase the size of the buffer for CC text
>   Make sure font color attribute is quoted.
>   Add support for monospace font in HTML renderer
>   Fix segfault of the font name is null.
>   Add support for font height as a percentage of the video height
>   Add ability to render the subpicture region, but not the text itself
>  include/vlc_subpicture.h         |    5 +--
>  modules/codec/cc.c               |   67 +++++++++++++++++++++++++++++---------
>  modules/codec/substext.h         |   13 ++++++++
>  modules/text_renderer/freetype.c |   67 +++++++++++++++++++++++++++++++++++++-
>  4 files changed, 134 insertions(+), 18 deletions(-)

Thanks for sending this into nicely separate small changes.

I tried to apply the first ones but they do not apply:

>From patch 0002:

diff --git a/modules/codec/cc.c b/modules/codec/cc.c
index e9590bc..86ec51e 100644
--- a/modules/codec/cc.c
+++ b/modules/codec/cc.c
@@ -1098,9 +1098,6 @@ static char *Eia608Text( eia608_t *h, bool b_html )

e9590bc does not exist,
cc.c is 1094 lines in git so the hunk can't start at line 1098..

Is it based on previous patches?

More information about the vlc-devel mailing list