[vlc-devel] [PATCH 2/4] Fix NP_GetMIMEDescription const check

Cheng Sun cheng.sun at ymail.com
Mon Dec 31 00:07:06 CET 2012

On 30/12/12 22:58, Rafaël Carré wrote:
> Le 30/12/2012 21:51, Cheng Sun a écrit :
> The commit log is a bit light.

Apologies, but I don't see how I could expand on it.

> git grep NPP_GET_MIME_CONST shows both functions are used: NP_ prefix
> and NPP_ prefix.
> Why is checking one better than the other?

Because NP_GetMIMEDescription is defined in <npfunctions.h> by the npapi
SDK, but NPP_GetMIMEDescription is defined by us. We obviously want to
check the former.

> When is one returning const and not the other?

Never. Both have to return the same, but that's exactly the problem. We
need to check what Mozilla says, not what we say.

- Cheng

More information about the vlc-devel mailing list