[vlc-devel] [vlc-commits] chromaprint: add stream out chromaprint module

[Rafaël Carré]

Le 30/12/2012 23:05, Rémi Denis-Courmont a écrit :
> This commit broke the build and will be reverted.

I asked Francois to remove his last commits.

Francois, since you sent a patch series on this list for review, and
people give you remarks, the decent thing to do is to send it again
after fixing until there are no more remarks.

I consider this basic etiquette but apparently it is not the way you see it.

Do we need a set of rules for committers?

> On Sun, 30 Dec 2012 22:34:41 +0100 (CET), git at videolan.org (Francois
> Cartegnie) wrote:
>> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Mon Nov
> 19
>> 19:32:30 2012 +0100| [1c22ca28aa9163abf73b385de32807c1e884d872] |
>> committer: Francois Cartegnie
>>
>> chromaprint: add stream out chromaprint module
>>
>>>
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=1c22ca28aa9163abf73b385de32807c1e884d872
>> ---
>>
>>  configure.ac                          |   18 +++
>>  modules/stream_out/Modules.am         |    2 +
>>  modules/stream_out/chromaprint.c      |  234
>>  +++++++++++++++++++++++++++++++++
>>  modules/stream_out/chromaprint_data.h |   27 ++++
>>  4 files changed, 281 insertions(+)
>>
>> Diff:  
>>
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=1c22ca28aa9163abf73b385de32807c1e884d872