[vlc-devel] [PATCH] aout intf: implement functions to change volume and also show the appropriate osd text

[David Fuhrmann]

Am 01.02.2012 um 15:59 schrieb Felix Paul Kühne:

> Hello,
> 
> On 01.02.2012, at 15:52, David Fuhrmann wrote:
> 
>>> OSD stuff does not belong in aout.
>> 
>> I repeatedly asked where would be the best place to implement this functionality. Up to now I got no useful answer. For me the current place seems to be the most sensible one.
>> It would be good to get a clear proposition from one of you about this. ;-)
> 
> IMO, the OSD code should be called directly from the interface within the respective methods. A good place would be the CoreInteraction class and its audio related called.

Yeah, I suggested that already.
But I also understand that it might be sensible to put that into the core, to make the code reusable for other interfaces (qt etc.), which need that feature, too.

Attached is a version which doesn't need the global variables any longer.

Best regards,
David


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-aout-intf-implement-functions-to-change-volume-and-a.patch
Type: application/octet-stream
Size: 5305 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120201/c5a894a7/attachment.obj>