[vlc-devel] [PATCH 2/2] Android: disable speex

XilasZ xilasz at gmail.com
Thu Feb 2 20:14:20 CET 2012


ok, so 48510 Hz->44100 Hz is just a trick to force a resampler.

I checked the speex resampler module, and all samples are processed by
speex, even if input_rate == output_rate, so we loose cpu for nothing.

Patch attached.

2012/2/2 Måns Rullgård <mans at mansr.com>

> Rafaël Carré <funman at videolan.org> writes:
>
> > Le 2012-02-02 11:47, Edward Wang a écrit :
> >> On 12-02-02 11:41 AM, Rafaël Carré wrote:
> >>> I have a few questions: - why is speex codec disabled by your patch?
> >>> we use speex for decoding speex, encoding speex (doesn't matter for
> >>> android atm), and resampling.
> >> I have no idea what the speex codec is, for that, I believe we are using
> >> avcodec anyway:
> >>
> >> D/vlc     ( 6242): using decoder module "avcodec"
> >
> > See http://www.speex.org/
> >
> > If we want to replace it by avcodec then why not but is it faster?
>
> libavcodec does not have a speex decoder (or encoder), only a wrapper
> for libspeex.  If you want to decode speex today, you will have to use
> libspeex one way or another.
>
> --
> Måns Rullgård
> mans at mansr.com
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120202/3bfbfc1c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: speex-Check-if-we-really-need-to-run-the-resampler.patch
Type: application/octet-stream
Size: 984 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120202/3bfbfc1c/attachment.obj>


More information about the vlc-devel mailing list