[vlc-devel] [PATCH 2/3] dash added byte range requests

[Christopher Müller]

> Von: vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> bounces at videolan.org] Im Auftrag von Hugo Beauzée-Luyssen
> Gesendet: Donnerstag, 02. Februar 2012 12:26
> An: Mailing list for VLC media player developers
> Betreff: Re: [vlc-devel] [PATCH 2/3] dash added byte range requests
> 
> 2012/1/29 Christopher Müller <christopher.mueller at itec.uni-klu.ac.at>:
> >> Von: vlc-devel-bounces at videolan.org [mailto:vlc-devel-
> >> bounces at videolan.org] Im Auftrag von Hugo Beauzée-Luyssen
> >> Gesendet: Sonntag, 29. Jänner 2012 01:57
> >> An: Mailing list for VLC media player developers
> >> Betreff: Re: [vlc-devel] [PATCH 2/3] dash added byte range requests
> >>
> >> 2012/1/28 Christopher Müller <christopher.mueller at itec.uni-
> klu.ac.at>:
> >> >
> >> >
> >> >
> >>
> >> Hello,
> >>
> >> If I'm not mistaking, this patch makes HttpConnection use net_*
> >> instead of the old stream_* Maybe this should be split in another
> >> patch. Also, some attributes seems to be unused afterward
> >> (HttpConnection::urlStream) you should probably remove them.
> >> When you delete this->peekBuffer, you must use delete[] as it was
> >> allocated with new[] The class destructor should probably ensure the
> >> connection is closed, if closeSocket wasn't called, it feels more
> >> natural.
> >>
> >
> > Yes it uses net_* due to the fact that stream_* does not support byte
> ranges. Comments are added thx.
> >
> > BR
> > Chris
> >
> 
> Hello,
> 
> Patch doesn't apply, I guess you should rebase it against the 17parts
> from the 1st patch :)
> 

So rebased the other patches. The buffer stuff is with debug information.

BR
Chris