[vlc-devel] [PATCH] Contribs: ffmpeg, enable small when deactivating encoder

[Rafaël Carré]

On 2012-02-04 08:31, Jean-Baptiste Kempf wrote:
> On Sat, Feb 04, 2012 at 02:27:33PM +0100, Jean-Baptiste Kempf wrote :
>> ---
>>   contrib/src/ffmpeg/rules.mak |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/contrib/src/ffmpeg/rules.mak b/contrib/src/ffmpeg/rules.mak
>> index 98ce743..3255134 100644
>> --- a/contrib/src/ffmpeg/rules.mak
>> +++ b/contrib/src/ffmpeg/rules.mak
>> @@ -30,7 +30,7 @@ FFMPEGCONF += --enable-libmp3lame --enable-libvpx
>>   DEPS_ffmpeg += lame $(DEPS_lame) vpx $(DEPS_vpx)
>>   else
>>   FFMPEGCONF += --disable-encoders --disable-muxers
>> -# XXX: REVISIT --enable-small ?
>> +FFMPEGCONF += --enable-small --optflags=-O2
>>   endif
>
> So, this is a quite quick solution. But maybe we should de-couple
> small and encoders-deactivation.
> I just thought that if you deactivate encoders, this is mainly because
> you are on embedded devices, so you need small.
>
> Opinions?

This commit has not the intended effect and should be reverted.

Please check what --enable-small does exactly

>
> Best regards,
>