[vlc-devel] [PATCH 1/1] add bin to PATH to let libvlc.dll be found by vlc-cache-gen.exe

[Rafaël Carré]

Le 2012-02-05 06:46, Sergey Radionov a écrit :
> 2012/2/5 Sergey Radionov <rsatom at gmail.com>:
>> 2012/2/5 Rafaël Carré <funman at videolan.org>:
>>> Le 2012-02-04 22:14, Sergey Radionov a écrit :
>>>> 2012/2/5 Rafaël Carré <funman at videolan.org>:
>>>>> On 2012-02-04 07:12, Sergey Radionov wrote:
>>>>>>
>>>>>> 2011/12/25 Sergey Radionov<rsatom at gmail.com>:
>>>>>>>
>>>>>>> Fix "This application has failed to start because libvlc.dll
>>>>>>> was not found. Re-installing the application may fix this problem."
>>>>>>> during building of vlc under Windows.
>>>>>>> ---
>>>>>>>  Makefile.am |    1 +
>>>>>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>>>>>
>>>>>>> diff --git a/Makefile.am b/Makefile.am
>>>>>>> index 358ac5f..dae8ad1 100644
>>>>>>> --- a/Makefile.am
>>>>>>> +++ b/Makefile.am
>>>>>>> @@ -406,6 +406,7 @@ vlc$(EXEEXT):
>>>>>>>
>>>>>>>  ###############################################################################
>>>>>>>  install-exec-hook:
>>>>>>>        if test "$(build)" = "$(host)"; then \
>>>>>>> +               PATH="$(DESTDIR)$(bindir):$$PATH" \
>>>>>>>                LD_LIBRARY_PATH="$(DESTDIR)$(libdir):$$LD_LIBRARY_PATH" \
>>>>>>>                "$(DESTDIR)$(vlclibdir)/vlc-cache-gen$(EXEEXT)" \
>>>>>>>                         "$(DESTDIR)$(vlclibdir)/plugins" ; \
>>>>>>> --
>>>>>>> 1.7.7.1.msysgit.0
>>>>>>>
>>>>>>
>>>>>> ping?
>>>>>
>>>>>
>>>>> Looks ok to me.
>>>>>
>>>>> Is the same change needed for "make check" ?
>>>> I don't know. I am not very well understand build system of VLC.
>>>
>>> Try to run "make check"
>> Then I need try before answer.
> 
> make[5]: `test_timer.exe' is up to date.
>   CCLD   test_url.exe
> libtool: link: warning: `-no-install' is ignored for i686-pc-mingw32
> libtool: link: warning: assuming `-no-fast-install' instead
> url.o: In function `test_current_directory_path':
> e:\git\vlc-2.0\src\test/url.c:84: undefined reference to `asprintf'
> collect2: ld returned 1 exit status
> make[5]: *** [test_url.exe] Error 1
> make[5]: Leaving directory `/e/git/vlc-2.0/src/test'
> make[4]: *** [check-am] Error 2
> make[4]: Leaving directory `/e/git/vlc-2.0/src/test'
> make[3]: *** [check-recursive] Error 1
> make[3]: Leaving directory `/e/git/vlc-2.0/src'
> make[2]: *** [check] Error 2
> make[2]: Leaving directory `/e/git/vlc-2.0/src'
> make[1]: *** [check-recursive] Error 1
> make[1]: Leaving directory `/e/git/vlc-2.0'
> make: *** [check] Error 2
> 
> so I can't answer for you question... :)

Fair enough!

Patch applied, let's see about running the tests when they will build