[vlc-devel] [vlc-commits] hls: Don't download the same segment twice when prefetching.

[Frederic YHUEL]

On Tue, Feb 7, 2012 at 2:37 PM, Hugo Beauzée-Luyssen <beauze.h at gmail.com> wrote:
> On Tue, Feb 7, 2012 at 1:45 PM, Frederic YHUEL <fyhuel at viotech.net> wrote:
>>>
>>> Hello,
>>>
>>> This commit seems to have introduced a bug or revealed a libav one:
>>>
>>> If I don't revert it, I'm flooded with libavcodec errors:
>>>
>>> [0x8457908] avcodec decoder warning: cannot decode one frame (30836 bytes)
>>> [h264 @ 0x845df80] allocate_progress() overflow
>>> [h264 @ 0x845df80] get_buffer() failed (-1 0 0 (nil))
>>> [h264 @ 0x845df80] decode_slice_header error
>>>
>>> But the sound is fine.
>>>
>>> I did the test with the following m3u8:
>>> http://qthttp.apple.com.edgesuite.net/11piubpwiqubf06c/sl_vod.m3u8
>>>
>>> Best Regards,
>>>
>>> --
>>> Frédéric
>>
>> The relevant error message was:
>>
>> [h264 @ 0xb1ee1120] Width/height changing with frame threads is not
>> implemented. Update your Libav version to the newest one from Git. If
>> the problem still occurs, it means that your file has a feature which
>> has not been implemented.
>>
>> Sorry for the noise!
>>
>
> Well that makes sense since this patch has quite a good chance of
> triggering a stream change, thus (probably) changing the resolution.

Indeed... I thought HLS didn't have that problem, not only because I
never saw it before, but because each HLS being "self-contained", I
thought the decoder was automatically restarted or re-initialized
after a resolution switch. I was wrong!

> However, that's the point of adaptive streaming...

Yes indeed :-)

> After some tests, the same problem is triggered when changing
> bandwidth, though I don't remember seeing this earlier...
>

Weird... and annoying!

-- 
Frédéric