[vlc-devel] [PATCH] udev discovery: remove categories

[Rafaël Carré]

Le 2012-02-08 16:26, Rafaël Carré a écrit :
> Le 2012-02-08 16:14, Rémi Denis-Courmont a écrit :
>> Le mercredi 8 février 2012 21:24:29 Rafaël Carré, vous avez écrit :
>>> @@ -507,31 +521,20 @@ static char *alsa_get_name (struct udev_device *dev)
>>>      if (snd_ctl_pcm_info (ctl, pcm_info))
>>>          goto out;
>>>
>>> -    name = strdup (snd_pcm_info_get_name (pcm_info));
>>> +    const char *name = snd_pcm_info_get_name (pcm_info);
>>> +    const char *ven = alsa_get_vendor(dev);
>>> +    if (asprintf(&fullname, "%s - %s", ven ? ven : "?", name ? name : "?")
>>> < 0)
>>> +        fullname = NULL;
>>
>> Hmm? "Intel Corporation - Intel ICH6 - MIC ADC" looks excessive.
> 
> I think we should get rid of vendor completely.
> 
> But keep category only for discs, i.e.
>  - "GOLDENEYE (DVD)"
>  - "François Pérusse Vol. 8 (CD-DVD-ABCHIJKLNOP)"

Pushed that with a memleak fix.